AtlasEngine: Improve appearance of curly underlines #17501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All of these are with the Hack font: Before, 10pt, 100% scale, 800% zoom: After, 10pt, 100% scale, 800% zoom: Before, 10pt, 150% scale, 800% zoom: After, 10pt, 150% scale, 800% zoom: Before, 12pt, 300% scale, 400% zoom: After, 12pt, 300% scale, 400% zoom: Regarding the last image: The line is actually supposed to be 1px wide (according to the font's underline width). This probably best demonstrates how the previous pixel shader drew the line too "fat". |
zadjii-msft
approved these changes
Jul 2, 2024
DHowett
reviewed
Jul 2, 2024
| color = all(cell < backgroundCellCount) ? background[cell] : backgroundColor; | ||
| weights = float4(1, 1, 1, 1); | ||
| break; | ||
| } | ||
| case SHADING_TYPE_TEXT_GRAYSCALE: | ||
| { | ||
| // These are independent of the glyph texture and could be moved to the vertex shader or CPU side of things. | ||
| const float4 foreground = premultiplyColor(data.color); |
There was a problem hiding this comment.
??? did we learn something new about const here?
DHowett
approved these changes
Jul 2, 2024
DHowett
pushed a commit
that referenced
this pull request
Aug 13, 2024
We'd previously subtract one underline-height from the curly line offset, even though we already had subtracted its complete height. Additionally, the pixel shader received some fine tuning: * Shrink the stroke width so that the anti-aliasing can be seen all the way up to the horizontal edges of the bounding box. * Add a phase shift to break apart the symmetry of the curve. Closes #17482 Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com> (cherry picked from commit ad3797a) Service-Card-Id: 92942049 Service-Version: 1.21
DHowett
pushed a commit
that referenced
this pull request
Aug 13, 2024
microsoft-github-policy-service
bot
added
Issue-Task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd previously subtract one underline-height from the curly line
offset, even though we already had subtracted its complete height.
Additionally, the pixel shader received some fine tuning:
all the way up to the horizontal edges of the bounding box.
Closes #17482
Co-authored-by: Carlos Zamora carlos.zamora@microsoft.com